Update testing-how-to.md #2839
Merged
Update testing-how-to.md #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for replicated-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for replicated-docs-upgrade ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
replicated-ci
added
type::docs
jdewinne
previously approved these changes
Nov 19, 2024
docs/vendor/testing-how-to.md
Outdated
| @@ -42,9 +42,12 @@ To create a cluster using the Replicated CLI: | |||
| Where: | |||
| * `NAME` is any name for the cluster. If `--name` is excluded, a name is automatically generated for the cluster. | |||
| * `K8S_DISTRO` is the Kubernetes distribution for the cluster. | |||
| * `K8S_VERSION` is the Kubernetes version for the cluster. | |||
| * `K8S_VERSION` is the Kubernetes version for the cluster if creating a standard Cloud or VM based cluster. | |||
| * When creating an Embedded Cluster type using `cluster create`, use of `--version` is optional, and the value passed should be the `Channel release sequence` value if not using "latest" | |||
There was a problem hiding this comment.
Isn't this going to result in people actually trying --version latest for EC? Which will not work, as it should be a channel sequence number.
| @@ -267,7 +267,7 @@ Compatibility Matrix supports creating [kURL](https://kurl.sh) clusters. | |||
| </tr> | |||
| <tr> | |||
| <th>Supported kURL Versions</th> | |||
| <td>Any promoted kURL installer. For an installer version other than "latest", you can find the ID for previously promoted installers on the **Channels > kURL Installer History** page in the Vendor Portal. For more information about viewing the history of kURL installers promoted to a channel, see [Installer History](/vendor/installer-history).</td> | |||
| <td>Any promoted kURL installer. Version is optional. For an installer version other than "latest", you can find the ID for previously promoted installers on the **Channels > kURL Installer History** page in the Vendor Portal. For more information about viewing the history of kURL installers promoted to a channel, see [Installer History](/vendor/installer-history).</td> | |||
There was a problem hiding this comment.
Should we clarify it needs to be the slug, and not the sequence number for kURL?
| @@ -37,14 +37,17 @@ To create a cluster using the Replicated CLI: | |||
| 1. Run the following command to create a cluster: | |||
|
|
|||
| ``` | |||
| replicated cluster create --name NAME --distribution K8S_DISTRO --version K8S_VERSION --disk DISK_SIZE --instance-type INSTANCE_TYPE | |||
| replicated cluster create --name NAME --distribution K8S_DISTRO --version K8S_VERSION --disk DISK_SIZE --instance-type INSTANCE_TYPE [--license-id LICENSE_ID] | |||
There was a problem hiding this comment.
^ wrapped in brackets to indicate optionality
paigecalvert
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.